]> git.itanic.dy.fi Git - linux-stable/commit
blk-mq: make sure active queue usage is held for bio_integrity_prep()
authorChristoph Hellwig <hch@infradead.org>
Mon, 13 Nov 2023 03:52:31 +0000 (11:52 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 13 Nov 2023 15:52:52 +0000 (08:52 -0700)
commitb0077e269f6c152e807fdac90b58caf012cdbaab
tree2c958e264aee391420f196ffab37239800849702
parentb85ea95d086471afb4ad062012a4d73cd328fa86
blk-mq: make sure active queue usage is held for bio_integrity_prep()

blk_integrity_unregister() can come if queue usage counter isn't held
for one bio with integrity prepared, so this request may be completed with
calling profile->complete_fn, then kernel panic.

Another constraint is that bio_integrity_prep() needs to be called
before bio merge.

Fix the issue by:

- call bio_integrity_prep() with one queue usage counter grabbed reliably

- call bio_integrity_prep() before bio merge

Fixes: 900e080752025f00 ("block: move queue enter logic into blk_mq_submit_bio()")
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Link: https://lore.kernel.org/r/20231113035231.2708053-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c