]> git.itanic.dy.fi Git - linux-stable/commit
ath9k_htc: fix NULL pointer dereference at ath9k_htc_rxep()
authorTetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Tue, 21 Sep 2021 13:06:23 +0000 (22:06 +0900)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 20 Dec 2021 16:08:57 +0000 (18:08 +0200)
commitb0ec7e55fce65f125bd1d7f02e2dc4de62abee34
treeccbc5181d25d59c5fbb65b19ef7f4320f1aa444c
parent01e782c891083f1847c0b62902bfe3c2812566c6
ath9k_htc: fix NULL pointer dereference at ath9k_htc_rxep()

syzbot is reporting lockdep warning followed by kernel panic at
ath9k_htc_rxep() [1], for ath9k_htc_rxep() depends on ath9k_rx_init()
being already completed.

Since ath9k_htc_rxep() is set by ath9k_htc_connect_svc(WMI_BEACON_SVC)
 from ath9k_init_htc_services(), it is possible that ath9k_htc_rxep() is
called via timer interrupt before ath9k_rx_init() from ath9k_init_device()
is called.

Since we can't call ath9k_init_device() before ath9k_init_htc_services(),
let's hold ath9k_htc_rxep() no-op until ath9k_rx_init() completes.

Link: https://syzkaller.appspot.com/bug?extid=4d2d56175b934b9a7bf9
Reported-by: syzbot <syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tested-by: syzbot <syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/2b88f416-b2cb-7a18-d688-951e6dc3fe92@i-love.sakura.ne.jp
drivers/net/wireless/ath/ath9k/htc.h
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c