]> git.itanic.dy.fi Git - linux-stable/commit
ALSA: pcm: Fix potential Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 12 Dec 2018 21:36:28 +0000 (15:36 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 4 Apr 2019 15:13:49 +0000 (16:13 +0100)
commitb2bf1147c25726d907972e4800d5b5da14f66977
tree5e4484e2679fc7f84447b1e9f1e4606f8fb22efd
parent913fc5d772ddde218ac1623d1c6416cd1fe01b70
ALSA: pcm: Fix potential Spectre v1 vulnerability

commit 94ffb030b6d31ec840bb811be455dd2e26a4f43e upstream.

stream is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

sound/core/pcm.c:140 snd_pcm_control_ioctl() warn: potential spectre issue 'pcm->streams' [r] (local cap)

Fix this by sanitizing stream before using it to index pcm->streams

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/core/pcm.c