]> git.itanic.dy.fi Git - linux-stable/commit
media: dvb-usb-v2: af9035: fix missing unlock
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 6 Oct 2023 10:08:45 +0000 (12:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 09:27:35 +0000 (10:27 +0100)
commitb41c9692299fd6fecfe87534331384a9978b9bfb
tree8a500be7e3ce3cdd1785de2dc2f0b2495ba7c4fb
parentaa942874bf5a6eab6a90c9a078f9be01147864bc
media: dvb-usb-v2: af9035: fix missing unlock

[ Upstream commit f31b2cb85f0ee165d78e1c43f6d69f82cc3b2145 ]

Instead of returning an error, goto the mutex unlock at
the end of the function.

Fixes smatch warning:

drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
  Locked on  : 326,387
  Unlocked on: 465,467

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 7bf744f2de0a ("media: dvb-usb-v2: af9035: Fix null-ptr-deref in af9035_i2c_master_xfer")
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/dvb-usb-v2/af9035.c