]> git.itanic.dy.fi Git - linux-stable/commit
tools: ynl: fix handling of multiple mcast groups
authorJakub Kicinski <kuba@kernel.org>
Mon, 26 Feb 2024 21:40:18 +0000 (13:40 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 Feb 2024 23:24:34 +0000 (15:24 -0800)
commitb6c65eb20ffa8e3bd89f551427dbeee2876d72ca
tree74e06993edd7a30d8838958972572644cfe03c7a
parent4adfc94d4aeca1177e1188ba83c20ed581523fe1
tools: ynl: fix handling of multiple mcast groups

We never increment the group number iterator, so all groups
get recorded into index 0 of the mcast_groups[] array.

As a result YNL can only handle using the last group.
For example using the "netdev" sample on kernel with
page pool commands results in:

  $ ./samples/netdev
  YNL: Multicast group 'mgmt' not found

Most families have only one multicast group, so this hasn't
been noticed. Plus perhaps developers usually test the last
group which would have worked.

Fixes: 86878f14d71a ("tools: ynl: user space helpers")
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20240226214019.1255242-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/lib/ynl.c