]> git.itanic.dy.fi Git - linux-stable/commit
xen/blkfront: Only check REQ_FUA for writes
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Wed, 26 Apr 2023 16:40:05 +0000 (17:40 +0100)
committerJuergen Gross <jgross@suse.com>
Wed, 24 May 2023 14:35:39 +0000 (16:35 +0200)
commitb6ebaa8100090092aa602530d7e8316816d0c98d
treea43998b3c22124a5af21263bbca4253ea9f87ede
parentcbfac7707ba16619006a4fd60faac46303fd2f3e
xen/blkfront: Only check REQ_FUA for writes

The existing code silently converts read operations with the
REQ_FUA bit set into write-barrier operations. This results in data
loss as the backend scribbles zeroes over the data instead of returning
it.

While the REQ_FUA bit doesn't make sense on a read operation, at least
one well-known out-of-tree kernel module does set it and since it
results in data loss, let's be safe here and only look at REQ_FUA for
writes.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20230426164005.2213139-1-ross.lagerwall@citrix.com
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/block/xen-blkfront.c