]> git.itanic.dy.fi Git - linux-stable/commit
sysfs: handle failure path correctly for readdir()
authorMing Lei <ming.lei@canonical.com>
Wed, 20 Mar 2013 15:25:25 +0000 (23:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2013 17:16:36 +0000 (10:16 -0700)
commitb76c1eabd474cd44937fc60a26be2b926a366e55
treef9879ab69c65a4540e19b6a301bdc500228f831f
parentf366c8f271888f48e15cc7c0ab70f184c220c8a4
sysfs: handle failure path correctly for readdir()

commit e5110f411d2ee35bf8d202ccca2e89c633060dca upstream.

In case of 'if (filp->f_pos ==  0 or 1)' of sysfs_readdir(),
the failure from filldir() isn't handled, and the reference counter
of the sysfs_dirent object pointed by filp->private_data will be
released without clearing filp->private_data, so use after free
bug will be triggered later.

This patch returns immeadiately under the situation for fixing the bug,
and it is reasonable to return from readdir() when filldir() fails.

Reported-by: Dave Jones <davej@redhat.com>
Tested-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/dir.c