]> git.itanic.dy.fi Git - linux-stable/commit
dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 14 Dec 2020 11:56:52 +0000 (14:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Jan 2021 13:05:35 +0000 (14:05 +0100)
commitb77e0283efdc2c79d392cf8d7ae9cd5142427199
tree01cb6bbd8392de005b8ec7dc4861e0b506357867
parentf6dd8c259ab82ca3e44a22542202e061cb23978c
dmaengine: dw-edma: Fix use after free in dw_edma_alloc_chunk()

commit 595a334148449bd1d27cf5d6fcb3b0d718cb1b9f upstream.

If the dw_edma_alloc_burst() function fails then we free "chunk" but
it's still on the "desc->chunk->list" list so it will lead to a use
after free.  Also the "->chunks_alloc" count is incremented when it
shouldn't be.

In current kernels small allocations are guaranteed to succeed and
dw_edma_alloc_burst() can't fail so this will not actually affect
runtime.

Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/X9dTBFrUPEvvW7qc@mwanda
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/dw-edma/dw-edma-core.c