]> git.itanic.dy.fi Git - linux-stable/commit
kselftest: rtnetlink.sh: use grep_fail when expecting the cmd fail
authorHangbin Liu <liuhangbin@gmail.com>
Tue, 19 Dec 2023 06:57:37 +0000 (14:57 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 21 Dec 2023 08:32:13 +0000 (09:32 +0100)
commitb8056f2ce07f27c43b9488dd1bc8bfbb60d0779d
tree63de45359ee06b2678a2c0345af3cc3a88e19c64
parentdade3f6a1e4e35a5ae916d5e78b3229ec34c78ec
kselftest: rtnetlink.sh: use grep_fail when expecting the cmd fail

run_cmd_grep_fail should be used when expecting the cmd fail, or the ret
will be set to 1, and the total test return 1 when exiting. This would cause
the result report to fail if run via run_kselftest.sh.

Before fix:
 # ./rtnetlink.sh -t kci_test_addrlft
 PASS: preferred_lft addresses have expired
 # echo $?
 1

After fix:
 # ./rtnetlink.sh -t kci_test_addrlft
 PASS: preferred_lft addresses have expired
 # echo $?
 0

Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231219065737.1725120-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/rtnetlink.sh