]> git.itanic.dy.fi Git - linux-stable/commit
scsi: vmw_pscsi: Fix use-after-free in pvscsi_queue_lck()
authorJan Kara <jack@suse.cz>
Wed, 19 Jun 2019 07:05:41 +0000 (09:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2019 11:16:00 +0000 (13:16 +0200)
commitb8124c39c70fa874f8aa84f37cda58ee6bd34903
tree0dd43810e02d084cacf714dbfb45ed8dc3cec45b
parentdd53bbb6538b5d0e871245ebd72dc95a015b49f7
scsi: vmw_pscsi: Fix use-after-free in pvscsi_queue_lck()

commit 240b4cc8fd5db138b675297d4226ec46594d9b3b upstream.

Once we unlock adapter->hw_lock in pvscsi_queue_lck() nothing prevents just
queued scsi_cmnd from completing and freeing the request. Thus cmd->cmnd[0]
dereference can dereference already freed request leading to kernel crashes
or other issues (which one of our customers observed). Store cmd->cmnd[0]
in a local variable before unlocking adapter->hw_lock to fix the issue.

CC: <stable@vger.kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/vmw_pvscsi.c