]> git.itanic.dy.fi Git - linux-stable/commit
drm/msm/adreno: fix runtime PM imbalance at gpu load
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 3 Mar 2023 16:48:05 +0000 (17:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 12:01:57 +0000 (14:01 +0200)
commitb8de0c4def919ee6138e2f1cd244f4329d763f76
tree9775c1756d3a917cfabf2ba62a3ec18646d578dd
parentae0bb54155052c82ec4f7d30cf284e911a4ae096
drm/msm/adreno: fix runtime PM imbalance at gpu load

commit 0d997f95b70f98987ae031a89677c13e0e223670 upstream.

A recent commit moved enabling of runtime PM to GPU load time (first
open()) but failed to update the error paths so that runtime PM is
disabled if initialisation of the GPU fails. This would trigger a
warning about the unbalanced disable count on the next open() attempt.

Note that pm_runtime_put_noidle() is sufficient to balance the usage
count when pm_runtime_put_sync() fails (and is chosen over
pm_runtime_resume_and_get() for consistency reasons).

Fixes: 4b18299b3365 ("drm/msm/adreno: Defer enabling runpm until hw_init()")
Cc: stable@vger.kernel.org # 6.0
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Patchwork: https://patchwork.freedesktop.org/patch/524971/
Link: https://lore.kernel.org/r/20230303164807.13124-3-johan+linaro@kernel.org
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/msm/adreno/adreno_device.c