]> git.itanic.dy.fi Git - linux-stable/commit
IB/hfi1: Drop stale TID RDMA packets that cause TIDErr
authorKaike Wan <kaike.wan@intel.com>
Thu, 15 Aug 2019 19:20:58 +0000 (15:20 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2019 06:30:24 +0000 (08:30 +0200)
commitb9e0cc134d735e3599f119f57d2d988ba177c464
treeb109d5af3d1225cb85a6c199e5f0f80f8992f8e7
parenta382c2b3d9c2923a40098fe579032fbccaddde90
IB/hfi1: Drop stale TID RDMA packets that cause TIDErr

commit d9d1f5e7bb82415591e8b62b222cbb88c4797ef3 upstream.

In a congested fabric with adaptive routing enabled, traces show that
packets could be delivered out of order. A stale TID RDMA data packet
could lead to TidErr if the TID entries have been released by duplicate
data packets generated from retries, and subsequently erroneously force
the qp into error state in the current implementation.

Since the payload has already been dropped by hardware, the packet can
be simply dropped and it is no longer necessary to put the qp into
error state.

Fixes: 9905bf06e890 ("IB/hfi1: Add functions to receive TID RDMA READ response")
Cc: <stable@vger.kernel.org>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Link: https://lore.kernel.org/r/20190815192058.105923.72324.stgit@awfm-01.aw.intel.com
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/infiniband/hw/hfi1/tid_rdma.c