]> git.itanic.dy.fi Git - linux-stable/commit
kernfs: annotate different lockdep class for of->mutex of writable files
authorAmir Goldstein <amir73il@gmail.com>
Fri, 5 Apr 2024 14:56:35 +0000 (17:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2024 09:23:40 +0000 (11:23 +0200)
commitbb43c568f74f843b3e8547d125d82a6ec6a1a61e
treea8a262fbf454dc0a2064fb91a244068f220d43c9
parentbbb2d4c71e86874762ed3e0133d53c2b8e206f20
kernfs: annotate different lockdep class for of->mutex of writable files

commit 16b52bbee4823b01ab7fe3919373c981a38f3797 upstream.

The writable file /sys/power/resume may call vfs lookup helpers for
arbitrary paths and readonly files can be read by overlayfs from vfs
helpers when sysfs is a lower layer of overalyfs.

To avoid a lockdep warning of circular dependency between overlayfs
inode lock and kernfs of->mutex, use a different lockdep class for
writable and readonly kernfs files.

Reported-by: syzbot+9a5b0ced8b1bfb238b56@syzkaller.appspotmail.com
Fixes: 0fedefd4c4e3 ("kernfs: sysfs: support custom llseek method for sysfs entries")
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/file.c