]> git.itanic.dy.fi Git - linux-stable/commit
powerpc/btext: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 20 Nov 2015 20:33:23 +0000 (20:33 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:28 +0000 (09:04 +0100)
commitbcad15b13cf11d6c62fb5af30e37b29ae13ef548
tree1cdf9accbd09ebee18699a41696ac10d28742248
parent8a50ec331374c2de78a98a923506f00de70d1683
powerpc/btext: add missing of_node_put

[ Upstream commit a1d2b210ffa52d60acabbf7b6af3ef7e1e69cda0 ]

for_each_node_by_type performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_node_by_type(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1448051604-25256-6-git-send-email-Julia.Lawall@lip6.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/kernel/btext.c