]> git.itanic.dy.fi Git - linux-stable/commit
selftests: bonding: do not set port down before adding to bond
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 17 Aug 2023 08:24:59 +0000 (16:24 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 22 Aug 2023 02:05:42 +0000 (19:05 -0700)
commitbe809424659c2844a2d7ab653aacca4898538023
tree5dd88b50eafb91c9ae5215fa59769e1e042d0dd6
parentd1cdbf66e18cd39dd749937221240ab97c06d9e6
selftests: bonding: do not set port down before adding to bond

Before adding a port to bond, it need to be set down first. In the
lacpdu test the author set the port down specifically. But commit
a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
changed the operation order, the kernel will set the port down _after_
adding to bond. So all the ports will be down at last and the test failed.

In fact, the veth interfaces are already inactive when added. This
means there's no need to set them down again before adding to the bond.
Let's just remove the link down operation.

Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
Reported-by: Zhengchao Shao <shaozhengchao@huawei.com>
Closes: https://lore.kernel.org/netdev/a0ef07c7-91b0-94bd-240d-944a330fcabd@huawei.com/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20230817082459.1685972-1-liuhangbin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh