]> git.itanic.dy.fi Git - linux-stable/commit
epoll: Keep a reference on files added to the check list
authorMarc Zyngier <maz@kernel.org>
Wed, 19 Aug 2020 16:12:17 +0000 (17:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Aug 2020 09:49:18 +0000 (11:49 +0200)
commitc09886c19233e1cdadb921d1f40566769b1e2037
tree8d54321463931a91849f41c28c389d369056731d
parent3489cea04a4bf0632dddd34424d0fe07d6d02f5b
epoll: Keep a reference on files added to the check list

commit a9ed4a6560b8562b7e2e2bed9527e88001f7b682 upstream.

When adding a new fd to an epoll, and that this new fd is an
epoll fd itself, we recursively scan the fds attached to it
to detect cycles, and add non-epool files to a "check list"
that gets subsequently parsed.

However, this check list isn't completely safe when deletions
can happen concurrently. To sidestep the issue, make sure that
a struct file placed on the check list sees its f_count increased,
ensuring that a concurrent deletion won't result in the file
disapearing from under our feet.

Cc: stable@vger.kernel.org
Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/eventpoll.c