]> git.itanic.dy.fi Git - linux-stable/commit
drm/amdgpu: drop redundant sched job cleanup when cs is aborted
authorGuchun Chen <guchun.chen@amd.com>
Wed, 26 Apr 2023 01:46:54 +0000 (09:46 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 11:59:05 +0000 (13:59 +0200)
commitc1564d4b105ae535eb3183ecaaa987685b20a888
tree24ebd07198ae47cc76f6adaa9b0ea76e1c5aa39b
parent8f98400925b50cd49b5e742ff226d7656dc7e2d3
drm/amdgpu: drop redundant sched job cleanup when cs is aborted

commit 1253685f0d3eb3eab0bfc4bf15ab341a5f3da0c8 upstream.

Once command submission failed due to userptr invalidation in
amdgpu_cs_submit, legacy code will perform cleanup of scheduler
job. However, it's not needed at all, as former commit has integrated
job cleanup stuff into amdgpu_job_free. Otherwise, because of double
free, a NULL pointer dereference will occur in such scenario.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2457
Fixes: f7d66fb2ea43 ("drm/amdgpu: cleanup scheduler job initialization v2")
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c