]> git.itanic.dy.fi Git - linux-stable/commit
firmware: arm_ffa: Fix usage of partition info get count flag
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 20 Apr 2023 15:06:02 +0000 (16:06 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 8 May 2023 19:40:46 +0000 (20:40 +0100)
commitc6e045361a27ecd4fac6413164e0d091d80eee99
treef776b41723770029d3c2fc8b606d6ba979343993
parentb71b55248a580e9c9befc4ae060539f1f8e477da
firmware: arm_ffa: Fix usage of partition info get count flag

Commit bb1be7498500 ("firmware: arm_ffa: Add v1.1 get_partition_info support")
adds support to discovery the UUIDs of the partitions or just fetch the
partition count using the PARTITION_INFO_GET_RETURN_COUNT_ONLY flag.

However the commit doesn't handle the fact that the older version doesn't
understand the flag and must be MBZ which results in firmware returning
invalid parameter error. That results in the failure of the driver probe
which is in correct.

Limit the usage of the PARTITION_INFO_GET_RETURN_COUNT_ONLY flag for the
versions above v1.0(i.e v1.1 and onwards) which fixes the issue.

Fixes: bb1be7498500 ("firmware: arm_ffa: Add v1.1 get_partition_info support")
Reported-by: Jens Wiklander <jens.wiklander@linaro.org>
Reported-by: Marc Bonnici <marc.bonnici@arm.com>
Tested-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Link: https://lore.kernel.org/r/20230419-ffa_fixes_6-4-v2-2-d9108e43a176@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_ffa/driver.c