]> git.itanic.dy.fi Git - linux-stable/commit
inotify: Avoid reporting event with invalid wd
authorJan Kara <jack@suse.cz>
Mon, 24 Apr 2023 16:32:19 +0000 (18:32 +0200)
committerJan Kara <jack@suse.cz>
Tue, 25 Apr 2023 10:36:55 +0000 (12:36 +0200)
commitc915d8f5918bea7c3962b09b8884ca128bfd9b0c
tree366e7c899862058ba8ed7190f20457149b7eefbd
parent173ea743bf7a9eef04460e03b00ba267cc52aee2
inotify: Avoid reporting event with invalid wd

When inotify_freeing_mark() races with inotify_handle_inode_event() it
can happen that inotify_handle_inode_event() sees that i_mark->wd got
already reset to -1 and reports this value to userspace which can
confuse the inotify listener. Avoid the problem by validating that wd is
sensible (and pretend the mark got removed before the event got
generated otherwise).

CC: stable@vger.kernel.org
Fixes: 7e790dd5fc93 ("inotify: fix error paths in inotify_update_watch")
Message-Id: <20230424163219.9250-1-jack@suse.cz>
Reported-by: syzbot+4a06d4373fd52f0b2f9c@syzkaller.appspotmail.com
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/inotify/inotify_fsnotify.c