]> git.itanic.dy.fi Git - linux-stable/commit
ixgbevf: Fix resource leak in ixgbevf_init_module()
authorShang XiaoJing <shangxiaojing@huawei.com>
Mon, 14 Nov 2022 02:57:58 +0000 (10:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Dec 2022 10:30:15 +0000 (11:30 +0100)
commitc99671d4699dcf90d6939923c8fe8a8918e140b2
tree0db3eca8d83f7ab4f001c4565ec2f4502d725960
parent35e0431d5f3a58c00aa1d83e8681c7e39d089aa3
ixgbevf: Fix resource leak in ixgbevf_init_module()

[ Upstream commit 8cfa238a48f34038464b99d0b4825238c2687181 ]

ixgbevf_init_module() won't destroy the workqueue created by
create_singlethread_workqueue() when pci_register_driver() failed. Add
destroy_workqueue() in fail path to prevent the resource leak.

Similar to the handling of u132_hcd_init in commit f276e002793c
("usb: u132-hcd: fix resource leak")

Fixes: 40a13e2493c9 ("ixgbevf: Use a private workqueue to avoid certain possible hangs")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c