]> git.itanic.dy.fi Git - linux-stable/commit
mmc: sdhci-pci: Do not disable interrupts in sdhci_intel_set_power
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 20 Mar 2017 17:50:30 +0000 (19:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2017 07:44:07 +0000 (09:44 +0200)
commitce6c155ada08872d3b80aaa9b4c13391397436fb
tree93f4931f844b0eb3f12594fb7c47792e32a69b8e
parentf89c8a5007b27107344417798f52ff694fb1b081
mmc: sdhci-pci: Do not disable interrupts in sdhci_intel_set_power

commit 027fb89e61054b4aedd962adb3e2003dec78a716 upstream.

Disabling interrupts for even a millisecond can cause problems for some
devices. That can happen when Intel host controllers wait for the present
state to propagate.

The spin lock is not necessary here. Anything that is racing with changes
to the I/O state is already broken. The mmc core already provides
synchronization via "claiming" the host.

Although the spin lock probably should be removed from the code paths that
lead to this point, such a patch would touch too much code to be suitable
for stable trees. Consequently, for this patch, just drop the spin lock
while waiting.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/sdhci-pci-core.c