]> git.itanic.dy.fi Git - linux-stable/commit
cifs: fix underflow in parse_server_interfaces()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 8 Feb 2024 10:18:46 +0000 (13:18 +0300)
committerSteve French <stfrench@microsoft.com>
Mon, 12 Feb 2024 01:07:08 +0000 (19:07 -0600)
commitcffe487026be13eaf37ea28b783d9638ab147204
tree27bc2db68a43e966b53061831d3bfe633654fa70
parent841c35169323cd833294798e58b9bf63fa4fa1de
cifs: fix underflow in parse_server_interfaces()

In this loop, we step through the buffer and after each item we check
if the size_left is greater than the minimum size we need.  However,
the problem is that "bytes_left" is type ssize_t while sizeof() is type
size_t.  That means that because of type promotion, the comparison is
done as an unsigned and if we have negative bytes left the loop
continues instead of ending.

Fixes: fe856be475f7 ("CIFS: parse and store info on iface queries")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2ops.c