]> git.itanic.dy.fi Git - linux-stable/commit
ipmi: ssif: replace strlcpy with strscpy
authorJason Wang <wangborong@cdjrlc.com>
Wed, 22 Dec 2021 03:27:07 +0000 (11:27 +0800)
committerCorey Minyard <cminyard@mvista.com>
Mon, 17 Jan 2022 15:10:46 +0000 (09:10 -0600)
commitd134ad2574a1c9b5c34659709769bdb25295fd25
tree6ae3a63b1365be410700a7963a2547da24c4c22e
parent7281599201c3336e350406781e7d88ca92453727
ipmi: ssif: replace strlcpy with strscpy

The strlcpy should not be used because it doesn't limit the source
length. So that it will lead some potential bugs.

But the strscpy doesn't require reading memory from the src string
beyond the specified "count" bytes, and since the return value is
easier to error-check than strlcpy()'s. In addition, the implementation
is robust to the string changing out from underneath it, unlike the
current strlcpy() implementation.

Thus, replace strlcpy with strscpy.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Message-Id: <20211222032707.1912186-1-wangborong@cdjrlc.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_ssif.c