]> git.itanic.dy.fi Git - linux-stable/commit
net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
authorOleksij Rempel <o.rempel@pengutronix.de>
Wed, 1 Apr 2020 09:57:32 +0000 (11:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2020 11:17:54 +0000 (13:17 +0200)
commitd2ec350b2727da304a5bb801a3ee8840e5a6558b
tree16bb6b11b7e18d85292b1901869b86eac90230ac
parentc963138042200a95a7ff5ce8b7a21b6c76e3c6e1
net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035

[ Upstream commit b1f4c209d84057b6d40b939b6e4404854271d797 ]

The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
for the values that comprise the fields, not zero-bits-set.

This patch fixes the clock frequency configuration for ATH8030 and
ATH8035 Atheros PHYs by removing the erroneous "~".

To reproduce this bug, configure the PHY  with the device tree binding
"qca,clk-out-frequency" and remove the machine specific PHY fixups.

Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/phy/at803x.c