]> git.itanic.dy.fi Git - linux-stable/commit
ext4: fix possible use after free in ext4_quota_enable
authorPan Bian <bianpan2016@163.com>
Tue, 4 Dec 2018 04:28:02 +0000 (23:28 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 09:07:11 +0000 (10:07 +0100)
commitd3f10a0116520e6ed383246eb877664c83308232
tree29b7d4e8edfae3b21d68662a63d0e7715bf62ba6
parentaf860a6a026a3b50cf49bc4602dcb882acae108e
ext4: fix possible use after free in ext4_quota_enable

commit 61157b24e60fb3cd1f85f2c76a7b1d628f970144 upstream.

The function frees qf_inode via iput but then pass qf_inode to
lockdep_set_quota_inode on the failure path. This may result in a
use-after-free bug. The patch frees df_inode only when it is never used.

Fixes: daf647d2dd5 ("ext4: add lockdep annotations for i_data_sem")
Cc: stable@kernel.org # 4.6
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c