]> git.itanic.dy.fi Git - linux-stable/commit
ext4: fix lost error code reporting in __ext4_fill_super()
authorTheodore Ts'o <tytso@mit.edu>
Thu, 27 Apr 2023 23:18:01 +0000 (19:18 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 28 Apr 2023 16:56:40 +0000 (12:56 -0400)
commitd5e72c4e3256335d6fb75c2e321144f93141f4f5
treee257e752ba56b70041947324686405514c185e52
parent856dd6c5981260b4d1aa84b78373ad54a203db48
ext4: fix lost error code reporting in __ext4_fill_super()

When code was factored out of __ext4_fill_super() into
ext4_percpu_param_init() the error return was discarded.  This meant
that it was possible for __ext4_fill_super() to return zero,
indicating success, without the struct super getting completely filled
in, leading to a potential NULL pointer dereference.

Reported-by: syzbot+bbf0f9a213c94f283a5c@syzkaller.appspotmail.com
Fixes: 1f79467c8a6b ("ext4: factor out ext4_percpu_param_init() ...")
Link: https://syzkaller.appspot.com/bug?id=6dac47d5e58af770c0055f680369586ec32e144c
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
fs/ext4/super.c