]> git.itanic.dy.fi Git - linux-stable/commit
drm/amd/display: Avoid enum conversion warning
authorNathan Chancellor <nathan@kernel.org>
Wed, 10 Jan 2024 20:46:47 +0000 (13:46 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 15 Jan 2024 23:35:07 +0000 (18:35 -0500)
commitd7643fe6fb76edb1f2f1497bf5e8b8f4774b5129
tree70a3b626d7134562439c2446bdf7be3361a4bc9a
parenta992c90d8ed3929b70ae815ce21ca5651cc0a692
drm/amd/display: Avoid enum conversion warning

Clang warns (or errors with CONFIG_WERROR=y) when performing arithmetic
with different enumerated types, which is usually a bug:

    drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:548:24: error: arithmetic between different enumeration types ('const enum dc_link_rate' and 'const enum dc_lane_count') [-Werror,-Wenum-enum-conversion]
      548 |                         link_cap->link_rate * link_cap->lane_count * LINK_RATE_REF_FREQ_IN_KHZ * 8;
          |                         ~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
    1 error generated.

In this case, there is not a problem because the enumerated types are
basically treated as '#define' values. Add an explicit cast to an
integral type to silence the warning.

Closes: https://github.com/ClangBuiltLinux/linux/issues/1976
Fixes: 5f3bce13266e ("drm/amd/display: Request usb4 bw for mst streams")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_dpia_bw.c