]> git.itanic.dy.fi Git - linux-stable/commit
rds: introduce acquire/release ordering in acquire/release_in_xmit()
authorYewon Choi <woni9911@gmail.com>
Fri, 15 Mar 2024 09:28:38 +0000 (18:28 +0900)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:35 +0000 (18:17 -0400)
commitd792459a6e2ae21c7f5107babd63e52e4c5ab93a
treef6b08783be9fe3de2d189bd7ff3122c4c8bee9a8
parentfdf16de078a97bf14bb8ee2b8d47cc3d3ead09ed
rds: introduce acquire/release ordering in acquire/release_in_xmit()

[ Upstream commit 1422f28826d2a0c11e5240b3e951c9e214d8656e ]

acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so they
are expected to ensure acquire/release memory ordering semantics.
However, test_and_set_bit/clear_bit() don't imply such semantics, on
top of this, following smp_mb__after_atomic() does not guarantee release
ordering (memory barrier actually should be placed before clear_bit()).

Instead, we use clear_bit_unlock/test_and_set_bit_lock() here.

Fixes: 0f4b1c7e89e6 ("rds: fix rds_send_xmit() serialization")
Fixes: 1f9ecd7eacfd ("RDS: Pass rds_conn_path to rds_send_xmit()")
Signed-off-by: Yewon Choi <woni9911@gmail.com>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Link: https://lore.kernel.org/r/ZfQUxnNTO9AJmzwc@libra05
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/rds/send.c