]> git.itanic.dy.fi Git - linux-stable/commit
selftests: fib_tests: Disable RP filter in multipath list receive test
authorIdo Schimmel <idosch@nvidia.com>
Tue, 10 Oct 2023 13:21:12 +0000 (16:21 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Oct 2023 21:28:22 +0000 (14:28 -0700)
commitdbb13378ba306484214b84304e232723a2aaf10a
tree9183a6b6d68849d4574b6b67df0be77d58e84e60
parent8702cf12e6ba91616a72d684e90357977972991b
selftests: fib_tests: Disable RP filter in multipath list receive test

The test relies on the fib:fib_table_lookup trace point being triggered
once for each forwarded packet. If RP filter is not disabled, the trace
point will be triggered twice for each packet (for source validation and
forwarding), potentially masking actual bugs. Fix by explicitly
disabling RP filter.

Before:

 # ./fib_tests.sh -t ipv4_mpath_list

 IPv4 multipath list receive tests
     TEST: Multipath route hit ratio (1.99)                              [ OK ]

After:

 # ./fib_tests.sh -t ipv4_mpath_list

 IPv4 multipath list receive tests
     TEST: Multipath route hit ratio (.99)                               [ OK ]

Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive tests")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel.com/
Tested-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Tested-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
Link: https://lore.kernel.org/r/20231010132113.3014691-2-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/fib_tests.sh