]> git.itanic.dy.fi Git - linux-stable/commit
net: ethernet: cortina: Fix MTU max setting
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 9 Nov 2023 09:03:14 +0000 (10:03 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 Nov 2023 04:58:20 +0000 (20:58 -0800)
commitdc6c0bfbaa947dd7976e30e8c29b10c868b6fa42
tree38d6cc86b3b1047de58ac138c7a725a6dc1f16d6
parentd4d0c5b4d279bfe3585fbd806efefd3e51c82afa
net: ethernet: cortina: Fix MTU max setting

The RX max frame size is over 10000 for the Gemini ethernet,
but the TX max frame size is actually just 2047 (0x7ff after
checking the datasheet). Reflect this in what we offer to Linux,
cap the MTU at the TX max frame minus ethernet headers.

We delete the code disabling the hardware checksum for large
MTUs as netdev->mtu can no longer be larger than
netdev->max_mtu meaning the if()-clause in gmac_fix_features()
is never true.

Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20231109-gemini-largeframe-fix-v4-3-6e611528db08@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cortina/gemini.c
drivers/net/ethernet/cortina/gemini.h