]> git.itanic.dy.fi Git - linux-stable/commit
media: mediatek: vcodec: Consider vdecsys presence in reg range check
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Wed, 26 Jul 2023 16:57:39 +0000 (12:57 -0400)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 27 Jul 2023 09:24:26 +0000 (11:24 +0200)
commitdd61c2a380037166517214957790a1486ae5d348
treeba0028faabacde28d3cc517090917912bdb34525
parent7baeedbe2bc6fac7d54f73e44605f6b7b40158ab
media: mediatek: vcodec: Consider vdecsys presence in reg range check

Commit fe8a33978383 ("media: mediatek: vcodec: Read HW active status
from syscon") allowed the driver to read the VDEC_SYS io space from a
syscon instead of from the reg property when reg-names are supplied.
However as part of that change, a smatch warning was introduced:

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:142 mtk_vcodec_get_reg_bases() error: buffer overflow 'mtk_dec_reg_names' 11 <= 11

With a correct Devicetree, that is, one that follows the dt-binding, it
wouldn't be possible to trigger such a buffer overflow. Even so, update
the range validation of the reg property, so that the smatch warning is
fixed and if an incorrect Devicetree is ever supplied the code errors
out instead of causing memory corruption.

Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Closes: https://lore.kernel.org/all/b5fd2dff-14a5-3ad8-9698-d1a50f4516fa@xs4all.nl
Fixes: fe8a33978383 ("media: mediatek: vcodec: Read HW active status from syscon")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c