]> git.itanic.dy.fi Git - linux-stable/commit
net: fix setting csum_start in skb_segment()
authorTom Herbert <therbert@google.com>
Wed, 25 Jun 2014 19:51:01 +0000 (12:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Jun 2014 03:45:54 +0000 (20:45 -0700)
commitde843723f9b989178762196fb24dd050cbe20ca3
tree6d73bfe2d0d6381db37e3fe40370e6fcb6b86b91
parentf88649721268999bdff09777847080a52004f691
net: fix setting csum_start in skb_segment()

Dave Jones reported that a crash is occurring in

csum_partial
tcp_gso_segment
inet_gso_segment
? update_dl_migration
skb_mac_gso_segment
__skb_gso_segment
dev_hard_start_xmit
sch_direct_xmit
__dev_queue_xmit
? dev_hard_start_xmit
dev_queue_xmit
ip_finish_output
? ip_output
ip_output
ip_forward_finish
ip_forward
ip_rcv_finish
ip_rcv
__netif_receive_skb_core
? __netif_receive_skb_core
? trace_hardirqs_on
__netif_receive_skb
netif_receive_skb_internal
napi_gro_complete
? napi_gro_complete
dev_gro_receive
? dev_gro_receive
napi_gro_receive

It looks like a likely culprit is that SKB_GSO_CB()->csum_start is
not set correctly when doing non-scatter gather. We are using
offset as opposed to doffset.

Reported-by: Dave Jones <davej@redhat.com>
Tested-by: Dave Jones <davej@redhat.com>
Signed-off-by: Tom Herbert <therbert@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 7e2b10c1e52ca ("net: Support for multiple checksums with gso")
Acked-by: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c