]> git.itanic.dy.fi Git - linux-stable/commit
Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fri, 2 Sep 2022 11:23:48 +0000 (20:23 +0900)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Mon, 19 Sep 2022 17:24:24 +0000 (10:24 -0700)
commitdeee93d13d385103205879a8a0915036ecd83261
tree088ffbba0066f818a36861a74a91f3ef45989ba5
parent2d2cb3066f2c90cd8ca540b36ba7a55e7f2406e0
Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works

syzbot is reporting attempt to schedule hdev->cmd_work work from system_wq
WQ into hdev->workqueue WQ which is under draining operation [1], for
commit c8efcc2589464ac7 ("workqueue: allow chained queueing during
destruction") does not allow such operation.

The check introduced by commit 877afadad2dce8aa ("Bluetooth: When HCI work
queue is drained, only queue chained work") was incomplete.

Use hdev->workqueue WQ when queuing hdev->{cmd,ncmd}_timer works because
hci_{cmd,ncmd}_timeout() calls queue_work(hdev->workqueue). Also, protect
the queuing operation with RCU read lock in order to avoid calling
queue_delayed_work() after cancel_delayed_work() completed.

Link: https://syzkaller.appspot.com/bug?extid=243b7d89777f90f7613b
Reported-by: syzbot <syzbot+243b7d89777f90f7613b@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Fixes: 877afadad2dce8aa ("Bluetooth: When HCI work queue is drained, only queue chained work")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/hci_core.c
net/bluetooth/hci_event.c