]> git.itanic.dy.fi Git - linux-stable/commit
drm/amdgpu: handle the case of pci_channel_io_frozen only in amdgpu_pci_resume
authorGuchun Chen <guchun.chen@amd.com>
Fri, 1 Oct 2021 01:48:50 +0000 (09:48 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 5 Oct 2021 16:23:56 +0000 (12:23 -0400)
commite17e27f9bdba274b404454072302cf5ea2282e5d
tree94a3e4da5164740b89e6f0b577b23f2dfb78e4d3
parent127aedf979579c3a638de37cc0288139f879585a
drm/amdgpu: handle the case of pci_channel_io_frozen only in amdgpu_pci_resume

In current code, when a PCI error state pci_channel_io_normal is detectd,
it will report PCI_ERS_RESULT_CAN_RECOVER status to PCI driver, and PCI
driver will continue the execution of PCI resume callback report_resume by
pci_walk_bridge, and the callback will go into amdgpu_pci_resume
finally, where write lock is releasd unconditionally without acquiring
such lock first. In this case, a deadlock will happen when other threads
start to acquire the read lock.

To fix this, add a member in amdgpu_device strucutre to cache
pci_channel_state, and only continue the execution in amdgpu_pci_resume
when it's pci_channel_io_frozen.

Fixes: c9a6b82f45e2 ("drm/amdgpu: Implement DPC recovery")
Suggested-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu.h
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c