]> git.itanic.dy.fi Git - linux-stable/commit
serial: omap: Disallow RS-485 if rts-gpio is not specified
authorLukas Wunner <lukas@wunner.de>
Sun, 11 Sep 2022 09:24:24 +0000 (11:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Sep 2022 14:10:45 +0000 (16:10 +0200)
commite2752ae3cfc9a486c5af38b302615705992c3a78
tree60ca60c73b7c7605dc6d50fe5f933513e787363e
parented9f4bb39624af6461774812888847a7d3f7f8b1
serial: omap: Disallow RS-485 if rts-gpio is not specified

The serial-omap driver requires an rts-gpio for RS-485 to work.
Historically it has allowed enabling RS-485 even if no rts-gpio was
specified in the device tree.

That doesn't make any sense, so disable RS-485 on probe if rts-gpio is
missing and disallow user space from enabling it.

Three NULL pointer checks for up->rts_gpiod can be dropped as a result,
simplifying the driver slightly.

Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/f191dcca0d8ea03598c463fc0d3fba8941ff2275.1662888075.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/omap-serial.c