]> git.itanic.dy.fi Git - linux-stable/commit
crypto: api - Add scaffolding to change completion function signature
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 31 Jan 2023 08:01:45 +0000 (16:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:50:20 +0000 (11:50 +0200)
commite7ce4ba11635ef23aa7ad40b4b9f9c52ef15f9e2
tree3652109ecd4d72331af809c9dd5c3b0d270655e5
parenta8cc4d5adfe5b6a9e7004e624dfe9a925727f871
crypto: api - Add scaffolding to change completion function signature

[ Upstream commit c35e03eaece71101ff6cbf776b86403860ac8cc3 ]

The crypto completion function currently takes a pointer to a
struct crypto_async_request object.  However, in reality the API
does not allow the use of any part of the object apart from the
data field.  For example, ahash/shash will create a fake object
on the stack to pass along a different data field.

This leads to potential bugs where the user may try to dereference
or otherwise use the crypto_async_request object.

This patch adds some temporary scaffolding so that the completion
function can take a void * instead.  Once affected users have been
converted this can be removed.

The helper crypto_request_complete will remain even after the
conversion is complete.  It should be used instead of calling
the completion function directly.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Stable-dep-of: 4140aafcff16 ("crypto: engine - fix crypto_queue backlog handling")
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/crypto/algapi.h
include/linux/crypto.h