]> git.itanic.dy.fi Git - linux-stable/commit
ALSA: au88x0: use explicitly signed char
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 24 Oct 2022 16:29:29 +0000 (18:29 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 25 Oct 2022 13:14:29 +0000 (15:14 +0200)
commitee03c0f200eb0d9f22dd8732d9fb7956d91019c2
tree71eb2fb1e32927d11901a5729e0449e53037f8b4
parentf86bfeb689f2c4ebe12782ef0578ef778fb1a050
ALSA: au88x0: use explicitly signed char

With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. This fixes warnings like:

sound/pci/au88x0/au88x0_core.c:2029 vortex_adb_checkinout() warn: signedness bug returning '(-22)'
sound/pci/au88x0/au88x0_core.c:2046 vortex_adb_checkinout() warn: signedness bug returning '(-12)'
sound/pci/au88x0/au88x0_core.c:2125 vortex_adb_allocroute() warn: 'vortex_adb_checkinout(vortex, (0), en, 0)' is unsigned
sound/pci/au88x0/au88x0_core.c:2170 vortex_adb_allocroute() warn: 'vortex_adb_checkinout(vortex, stream->resources, en, 4)' is unsigned

As well, since one function returns errnos, return an `int` rather than
a `signed char`.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221024162929.536004-1-Jason@zx2c4.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/au88x0/au88x0.h
sound/pci/au88x0/au88x0_core.c