]> git.itanic.dy.fi Git - linux-stable/commit
irqchip/loongson-eiointc: Fix returned value on parsing MADT
authorJianmin Lv <lvjianmin@loongson.cn>
Fri, 7 Apr 2023 08:34:49 +0000 (16:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 11:59:04 +0000 (13:59 +0200)
commitf07ba935ae34b1d00121fb4d5ceb3a79345aa165
tree8eb50567b8061593796fe264d0c8518b91edecd6
parent76de2c5b1757971b13a8811b876e74c4d5c48ba2
irqchip/loongson-eiointc: Fix returned value on parsing MADT

commit 112eaa8fec5ea75f1be003ec55760b09a86799f8 upstream.

In pch_pic_parse_madt(), a NULL parent pointer will be
returned from acpi_get_vec_parent() for second pch-pic domain
related to second bridge while calling eiointc_acpi_init() at
first time, where the parent of it has not been initialized
yet, and will be initialized during second time calling
eiointc_acpi_init(). So, it's reasonable to return zero so
that failure of acpi_table_parse_madt() will be avoided, or else
acpi_cascade_irqdomain_init() will return and initialization of
followed pch_msi domain will be skipped.

Although it does not matter when pch_msi_parse_madt() returns
-EINVAL if no invalid parent is found, it's also reasonable to
return zero for that.

Cc: stable@vger.kernel.org
Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230407083453.6305-2-lvjianmin@loongson.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/irqchip/irq-loongson-eiointc.c