]> git.itanic.dy.fi Git - linux-stable/commit
xprtrdma: Fix completion wait during device removal
authorChuck Lever <chuck.lever@oracle.com>
Fri, 3 Jan 2020 16:52:17 +0000 (11:52 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:47:04 +0000 (19:47 +0100)
commitf1e47dcc65e4198f7028a0fd3d012fc250568847
tree9dca9f2185df0f745ec8d5c2246ec7afa82345d6
parentb1152098d409d020b8ab494f24945fe81cf508ef
xprtrdma: Fix completion wait during device removal

commit 13cb886c591f341a8759f175292ddf978ef903a1 upstream.

I've found that on occasion, "rmmod <dev>" will hang while if an NFS
is under load.

Ensure that ri_remove_done is initialized only just before the
transport is woken up to force a close. This avoids the completion
possibly getting initialized again while the CM event handler is
waiting for a wake-up.

Fixes: bebd031866ca ("xprtrdma: Support unplugging an HCA from under an NFS mount")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/xprtrdma/verbs.c