]> git.itanic.dy.fi Git - linux-stable/commit
scsi: ufs: Uninitialized variable in ufshcd_devfreq_target()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 13 Feb 2024 18:08:09 +0000 (21:08 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 15 Feb 2024 19:46:13 +0000 (14:46 -0500)
commitf2dced9d1992824d677593072bc20eccf66ac5d5
tree27464a63feca6a6ea3b9ae9e9c5b29581b11db01
parentde959094eb2197636f7c803af0943cb9d3b35804
scsi: ufs: Uninitialized variable in ufshcd_devfreq_target()

There is one goto where "sched_clk_scaling_suspend_work" is true but
"scale_up" is uninitialized.  It leads to a Smatch uninitialized variable
warning:

drivers/ufs/core/ufshcd.c:1589 ufshcd_devfreq_target() error: uninitialized symbol 'scale_up'.

Fixes: 1d969731b87f ("scsi: ufs: core: Only suspend clock scaling if scaling down")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c787d37f-1107-4512-8991-bccf80e74a35@moroto.mountain
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c