]> git.itanic.dy.fi Git - linux-stable/commit
btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART
authorFilipe Manana <fdmanana@suse.com>
Wed, 26 Jul 2023 15:56:57 +0000 (16:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:23:01 +0000 (12:23 +0200)
commitf3260733894a3dff10ee271778af605ece0f331e
tree798bb223fe78f6c75b801f72e249b30d77247f98
parent7ef0e8b812e0c4e057f22515853195c7d2e03701
btrfs: don't start transaction when joining with TRANS_JOIN_NOSTART

commit 4490e803e1fe9fab8db5025e44e23b55df54078b upstream.

When joining a transaction with TRANS_JOIN_NOSTART, if we don't find a
running transaction we end up creating one. This goes against the purpose
of TRANS_JOIN_NOSTART which is to join a running transaction if its state
is at or below the state TRANS_STATE_COMMIT_START, otherwise return an
-ENOENT error and don't start a new transaction. So fix this to not create
a new transaction if there's no running transaction at or below that
state.

CC: stable@vger.kernel.org # 4.14+
Fixes: a6d155d2e363 ("Btrfs: fix deadlock between fiemap and transaction commits")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/transaction.c