]> git.itanic.dy.fi Git - linux-stable/commit
acpi/ghes: Remove CXL CPER notifications
authorDan Williams <dan.j.williams@intel.com>
Sun, 18 Feb 2024 22:28:57 +0000 (14:28 -0800)
committerDan Williams <dan.j.williams@intel.com>
Wed, 21 Feb 2024 06:50:52 +0000 (22:50 -0800)
commitf3e6b3ae9cfc128af11b665c6ef4022ba2683778
tree6c34f1b8db8c38ec6856e1427c76be979cd8a20c
parentb401b621758e46812da61fa58a67c3fd8d91de0d
acpi/ghes: Remove CXL CPER notifications

Initial tests with the CXL CPER implementation identified that error
reports were being duplicated in the log and the trace event [1].  Then
it was discovered that the notification handler took sleeping locks
while the GHES event handling runs in spin_lock_irqsave() context [2]

While the duplicate reporting was fixed in v6.8-rc4, the fix for the
sleeping-lock-vs-atomic collision would enjoy more time to settle and
gain some test cycles.  Given how late it is in the development cycle,
remove the CXL hookup for now and try again during the next merge
window.

Note that end result is that v6.8 does not emit CXL CPER payloads to the
kernel log, but this is in line with the CXL trend to move error
reporting to trace events instead of the kernel log.

Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: http://lore.kernel.org/r/20240108165855.00002f5a@Huawei.com
Closes: http://lore.kernel.org/r/b963c490-2c13-4b79-bbe7-34c6568423c7@moroto.mountain [2]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/acpi/apei/ghes.c
drivers/cxl/pci.c
include/linux/cxl-event.h