]> git.itanic.dy.fi Git - linux-stable/commit
ext4: fix deadlock when converting an inline directory in nojournal mode
authorTheodore Ts'o <tytso@mit.edu>
Sun, 7 May 2023 01:04:01 +0000 (21:04 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 13 May 2023 22:05:05 +0000 (18:05 -0400)
commitf4ce24f54d9cca4f09a395f3eecce20d6bec4663
tree236dd40a035004bf3a07896147cd1ae102ad3a5a
parent4c0b4818b1f636bc96359f7817a2d8bab6370162
ext4: fix deadlock when converting an inline directory in nojournal mode

In no journal mode, ext4_finish_convert_inline_dir() can self-deadlock
by calling ext4_handle_dirty_dirblock() when it already has taken the
directory lock.  There is a similar self-deadlock in
ext4_incvert_inline_data_nolock() for data files which we'll fix at
the same time.

A simple reproducer demonstrating the problem:

    mke2fs -Fq -t ext2 -O inline_data -b 4k /dev/vdc 64
    mount -t ext4 -o dirsync /dev/vdc /vdc
    cd /vdc
    mkdir file0
    cd file0
    touch file0
    touch file1
    attr -s BurnSpaceInEA -V abcde .
    touch supercalifragilisticexpialidocious

Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20230507021608.1290720-1-tytso@mit.edu
Reported-by: syzbot+91dccab7c64e2850a4e5@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=ba84cc80a9491d65416bc7877e1650c87530fe8a
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inline.c