]> git.itanic.dy.fi Git - linux-stable/commit
drm/amd/display: Reduce number of arguments of dml314's CalculateFlipSchedule()
authorNathan Chancellor <nathan@kernel.org>
Fri, 16 Sep 2022 21:06:58 +0000 (14:06 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Sep 2022 21:36:57 +0000 (17:36 -0400)
commitf525ed19437d376736bed64ee7bc4afee82f2ba9
tree4ea5e17f83ca584cdeaa4d4d68092c74975bae3e
parentfaed5d0182480556cddb8343d9bad968387848f4
drm/amd/display: Reduce number of arguments of dml314's CalculateFlipSchedule()

Most of the arguments are identical between the two call sites and they
can be accessed through the 'struct vba_vars_st' pointer. This reduces
the total amount of stack space that
dml314_ModeSupportAndSystemConfigurationFull() uses by 112 bytes with
LLVM 16 (1976 -> 1864), helping clear up the following clang warning:

  drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:4020:6: error: stack frame size (2216) exceeds limit (2048) in 'dml314_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than]
  void dml314_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib)
       ^
  1 error generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/1710
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Tested-by: MaĆ­ra Canal <mairacanal@riseup.net>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c