]> git.itanic.dy.fi Git - linux-stable/commit
arm64: cmpxchg: Use "K" instead of "L" for ll/sc immediate constraint
authorWill Deacon <will.deacon@arm.com>
Tue, 18 Sep 2018 08:39:55 +0000 (09:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 7 Mar 2021 11:18:54 +0000 (12:18 +0100)
commitf5c832bcb1947ce6339b5e6b7be189fa3c824ee2
tree5952bdcbe74c61a1f1091372daaa0935d25433cd
parent73152d61e44ce6a12cc1b58c6be0eeb44dca5f4b
arm64: cmpxchg: Use "K" instead of "L" for ll/sc immediate constraint

commit 4230509978f2921182da4e9197964dccdbe463c3 upstream.

The "L" AArch64 machine constraint, which we use for the "old" value in
an LL/SC cmpxchg(), generates an immediate that is suitable for a 64-bit
logical instruction. However, for cmpxchg() operations on types smaller
than 64 bits, this constraint can result in an invalid instruction which
is correctly rejected by GAS, such as EOR W1, W1, #0xffffffff.

Whilst we could special-case the constraint based on the cmpxchg size,
it's far easier to change the constraint to "K" and put up with using
a register for large 64-bit immediates. For out-of-line LL/SC atomics,
this is all moot anyway.

Reported-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/include/asm/atomic_ll_sc.h