]> git.itanic.dy.fi Git - linux-stable/commit
ksmbd: fix racy issue from session setup and logoff
authorNamjae Jeon <linkinjeon@kernel.org>
Wed, 3 May 2023 07:45:00 +0000 (16:45 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:53:56 +0000 (11:53 +0200)
commitf623f627ad2b1dc215ab3b0df53fb05cfd3a1c3b
tree514cf99f8452e8331bed8a79a75685b369e35b32
parent91bbf9cb2387a0d76322e9a343bc6bc160f66b3f
ksmbd: fix racy issue from session setup and logoff

[ Upstream commit f5c779b7ddbda30866cf2a27c63e34158f858c73 ]

This racy issue is triggered by sending concurrent session setup and
logoff requests. This patch does not set connection status as
KSMBD_SESS_GOOD if state is KSMBD_SESS_NEED_RECONNECT in session setup.
And relookup session to validate if session is deleted in logoff.

Cc: stable@vger.kernel.org
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-20481, ZDI-CAN-20590, ZDI-CAN-20596
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ksmbd/connection.c
fs/ksmbd/connection.h
fs/ksmbd/mgmt/user_session.c
fs/ksmbd/server.c
fs/ksmbd/smb2pdu.c
fs/ksmbd/transport_tcp.c