]> git.itanic.dy.fi Git - linux-stable/commit
can: gs_usb: gs_can_close(): add missing set of CAN state to CAN_STATE_STOPPED
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 18 Jul 2023 09:43:54 +0000 (11:43 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 20 Jul 2023 09:12:45 +0000 (11:12 +0200)
commitf8a2da6ec2417cca169fa85a8ab15817bccbb109
treea1eebcc6b007e92a7b6b464cbf0ce6ef0565531d
parent9f9d4c1a2e82174a4e799ec405284a2b0de32b6a
can: gs_usb: gs_can_close(): add missing set of CAN state to CAN_STATE_STOPPED

After an initial link up the CAN device is in ERROR-ACTIVE mode. Due
to a missing CAN_STATE_STOPPED in gs_can_close() it doesn't change to
STOPPED after a link down:

| ip link set dev can0 up
| ip link set dev can0 down
| ip --details link show can0
| 13: can0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 10
|     link/can  promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
|     can state ERROR-ACTIVE restart-ms 1000

Add missing assignment of CAN_STATE_STOPPED in gs_can_close().

Cc: stable@vger.kernel.org
Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Link: https://lore.kernel.org/all/20230718-gs_usb-fix-can-state-v1-1-f19738ae2c23@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c