]> git.itanic.dy.fi Git - linux-stable/commit
powerpc: Initialise paca->kstack before early_setup_secondary
authorMatt Evans <matt@ozlabs.org>
Thu, 12 Aug 2010 20:58:28 +0000 (20:58 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:44:13 +0000 (21:44 -0700)
commitf9ca496a7390afd89f5b797bb4f4bf44ec3b4525
tree7421b878375b23d61c8f8c60bdfb2baec2afea76
parente25a2ee620d3cb1e98c697aaa0d802a77c8256fb
powerpc: Initialise paca->kstack before early_setup_secondary

commit f761622e59433130bc33ad086ce219feee9eb961 upstream.

As early setup calls down to slb_initialize(), we must have kstack
initialised before checking "should we add a bolted SLB entry for our kstack?"

Failing to do so means stack access requires an SLB miss exception to refill
an entry dynamically, if the stack isn't accessible via SLB(0) (kernel text
& static data).  It's not always allowable to take such a miss, and
intermittent crashes will result.

Primary CPUs don't have this issue; an SLB entry is not bolted for their
stack anyway (as that lives within SLB(0)).  This patch therefore only
affects the init of secondaries.

Signed-off-by: Matt Evans <matt@ozlabs.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/powerpc/kernel/head_64.S