]> git.itanic.dy.fi Git - linux-stable/commit
team: reset team's flags when down link is P2P device
authorHangbin Liu <liuhangbin@gmail.com>
Fri, 21 Jul 2023 04:03:56 +0000 (12:03 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 25 Jul 2023 07:16:17 +0000 (09:16 +0200)
commitfa532bee17d15acf8bba4bc8e2062b7a093ba801
tree7e1dfa5678ef9b60f08959a7a646f00738469613
parentda19a2b967cf1e2c426f50d28550d1915214a81d
team: reset team's flags when down link is P2P device

When adding a point to point downlink to team device, we neglected to reset
the team's flags, which were still using flags like BROADCAST and
MULTICAST. Consequently, this would initiate ARP/DAD for P2P downlink
interfaces, such as when adding a GRE device to team device. Fix this by
remove multicast/broadcast flags and add p2p and noarp flags.

After removing the none ethernet interface and adding an ethernet interface
to team, we need to reset team interface flags. Unlike bonding interface,
team do not need restore IFF_MASTER, IFF_SLAVE flags.

Reported-by: Liang Li <liali@redhat.com>
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2221438
Fixes: 1d76efe1577b ("team: add support for non-ethernet devices")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/team/team.c