]> git.itanic.dy.fi Git - linux-stable/commit
can: gs_usb: gs_can_open(): fix race dev->can.state condition
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 20 Sep 2022 09:40:56 +0000 (11:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 08:56:51 +0000 (10:56 +0200)
commitfebce6921450ecf6dcc6c7272a3709994be49953
tree20245d02330b26b66628e16da50980f9a8b6631a
parent754e8b74281dd54a324698803483f47cf3355ae1
can: gs_usb: gs_can_open(): fix race dev->can.state condition

[ Upstream commit 5440428b3da65408dba0241985acb7a05258b85e ]

The dev->can.state is set to CAN_STATE_ERROR_ACTIVE, after the device
has been started. On busy networks the CAN controller might receive
CAN frame between and go into an error state before the dev->can.state
is assigned.

Assign dev->can.state before starting the controller to close the race
window.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Link: https://lore.kernel.org/all/20220920195216.232481-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/usb/gs_usb.c